#354 common menu state composable added #539
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is a security feature by github, for first-time contributors. A maintainer needs to approve the execution of workflows.
|
|
Hmmm strange :( Must have just been some latency on their end as I wasn't seeing it as an option :) Just that there was no conflicts, and the maintainer checklist also didn't fire. Thanks @to-sta! |
| @@ -257,23 +257,23 @@ const createButtons: MenuSelector[] = [ | |||
| const infoButtons: MenuSelector[] = [ | |||
| { | |||
| id: 1, | |||
| label: "_global.help", | |||
| label: "components.sidebar-left-selector.label.help", | |||
There was a problem hiding this comment.
Noting that this has some i18n keys that are being replaced :)
|
|
||
| const organizationEntries = ref([ | ||
| createMenuEntry("_global.about", "organizations", "bi:card-text", true), | ||
| createMenuEntry("components.sidebar-left-selector.label.events", "organizations", "bi:calendar-check", true), |
There was a problem hiding this comment.
I'm expecting that these i18n keys should also be replaced with _global variants :)
There was a problem hiding this comment.
This is great stuff here, @Robert-Kovalcuk! Thanks so much for getting all this done with such a high level of care for us using the right practices. The only thing I'm noting now is that for mobile the page isn't changing when we use the keyboard to select the option and return to select it. This can be another issue though 😊
Goal is to make new issues this evening after the talk I have. Will be in touch!
|
I'll fix the i18n keys as well 🙃 |
|
Sounds good, Looking forward to contributing as much as a I can) |
Contributor checklist
Description
Related issue